linux-kernel - Re: [PATCH v4 2/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Nov 2019 19:58:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Matheus Castello <matheus@...tello.eng.br>
Cc:     sre@...nel.org, krzk@...nel.org, mark.rutland@....com,
        cw00.choi@...sung.com, b.zolnierkie@...sung.com,
        lee.jones@...aro.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: power: supply: Max17040: Add low
 level SOC alert threshold

On Thu, Oct 31, 2019 at 03:41:32PM -0300, Matheus Castello wrote:
> For configure low level state of charge threshold alert signaled from
> max17040 we add "maxim,alert-low-soc-level" property.

This doesn't match the change. You're adding a whole new device binding.

> Signed-off-by: Matheus Castello <matheus@...tello.eng.br>
> ---
>  .../power/supply/max17040_battery.txt         | 33 +++++++++++++++++++

Part of an MFD? The MFD binding should reference this file then.

>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> new file mode 100644
> index 000000000000..f2d0b22b5f79
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> @@ -0,0 +1,33 @@
> +max17040_battery
> +~~~~~~~~~~~~~~~~
> +
> +Required properties :
> + - compatible : "maxim,max17040" or "maxim,max77836-battery"
> + - reg: i2c slave address
> +
> +Optional properties :
> +- maxim,alert-low-soc-level :	The alert threshold that sets the state of
> + 				charge level (%) where an interrupt is
> +				generated. Can be configured from 1 up to 32
> +				(%). If skipped the power up default value of
> +				4 (%) will be used.

Seems like something that should be a common battery property.

> +- interrupts : 			Interrupt line see Documentation/devicetree/
> +				bindings/interrupt-controller/interrupts.txt
> +- wakeup-source :		This device has wakeup capabilities. Use this
> +				property to use alert low SOC level interrupt
> +				as wake up source.
> +
> +Optional properties support interrupt functionality for alert low state of
> +charge level, present in some ICs in the same family, and should be used with
> +compatible "maxim,max77836-battery".
> +
> +Example:
> +
> +	battery-fuel-gauge@36 {
> +		compatible = "maxim,max77836-battery";
> +		reg = <0x36>;
> +		maxim,alert-low-soc-level = <10>;
> +		interrupt-parent = <&gpio7>;
> +		interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> +		wakeup-source;
> +	};
> --
> 2.24.0.rc2
>