linux-kernel - Re: [PATCH v15 0/4] overlayfs override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOQ4uxindmuTdfW6NNM2=Bt=y7KDMQsfN=zA_Z7dgkrHfptoHA@mail.gmail.com>
Date:   Tue, 5 Nov 2019 21:25:44 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Mark Salyzyn <salyzyn@...roid.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        kernel-team@...roid.com, Miklos Szeredi <miklos@...redi.hu>,
        Jonathan Corbet <corbet@....net>,
        Vivek Goyal <vgoyal@...hat.com>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        overlayfs <linux-unionfs@...r.kernel.org>,
        linux-doc@...r.kernel.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v15 0/4] overlayfs override_creds=off & nested get xattr fix

On Tue, Nov 5, 2019 at 5:20 PM Mark Salyzyn <salyzyn@...roid.com> wrote:
>
> On 11/4/19 11:56 PM, Amir Goldstein wrote:
> > On Mon, Nov 4, 2019 at 11:53 PM Mark Salyzyn <salyzyn@...roid.com> wrote:
> >> Patch series:
> >>
> >> Mark Salyzyn (4):
> >>    Add flags option to get xattr method paired to __vfs_getxattr
> > Sigh.. did not get to fsdevel (again...) I already told you several times
> > that you need to use a shorter CC list.
>
> This is a direct result of the _required_ scripts/get_maintainer.pl
> logic, I am not going to override it for first send. I was going to
> forward to fsdevel after the messages settled, I am still waiting for
> 1/4 to land on lore before continuing.

How do you expect it to land in lore if the mailing list server rejects it?
If I were you, I would *first* post the patch to the small crowd of the
patch set, which includes fsdevel and *then* forward patch 1 to all
maintainers with a link to lore for the series.

The result as is was in your last 15 posting is much worst.
There is a ghost patch in the series that nobody knows where to find.

>
> The first patch in the series needs to get in before the others. I was
> told to send the first one individually because the series has so many
> recipients and stakeholders, and <crickets> because no on could see the
> reason for the patch once it was all by itself. So I rejoined the set so
> they could see the reason for the first patch.
>
> If only the first patch in the series that added the flag argument got
> in (somewhere), then the overlayfs portion would be much easier to handle.
>
> >>    overlayfs: handle XATTR_NOSECURITY flag for get xattr method
> >>    overlayfs: internal getxattr operations without sepolicy checking
> >>    overlayfs: override_creds=off option bypass creator_cred
> > It would be better for review IMO if you rebase your series on top of
> > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git ovl-unpriv
> Will do, send it only to fsdevel, other recipients? What do I do with
> get_maintainer.pl? The first patch in the series is noisy, I am getting
> more and more uncomfortable sending it to the list as it looks more and
> more like spam.

get_maintainer.pl is a suggestion. common sense should be applied.
Sending the entire series to the crowd of this message seems fine to
me (I also added fsdevel). LKML is quite an overkill IMO and
linux-doc also seems out of context if you ask me.

Thanks,
Amir.