linux-kernel - Re: [PATCH] ASoC: wm8524: Add support S32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <VE1PR04MB64790EF282B41CB04EA6707DE37E0@VE1PR04MB6479.eurprd04.prod.outlook.com>
Date:   Tue, 5 Nov 2019 03:25:55 +0000
From:   "S.j. Wang" <shengjiu.wang@....com>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "allison@...utok.net" <allison@...utok.net>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "info@...ux.net" <info@...ux.net>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: wm8524: Add support S32_LE

Hi

> On Fri, Nov 01, 2019 at 06:34:54AM +0000, S.j. Wang wrote:
> > Allow 32bit sample with this codec.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > ---
> >  sound/soc/codecs/wm8524.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/codecs/wm8524.c b/sound/soc/codecs/wm8524.c
> > index 91e3d1570c45..4e9ab542f648 100644
> > --- a/sound/soc/codecs/wm8524.c
> > +++ b/sound/soc/codecs/wm8524.c
> > @@ -159,7 +159,9 @@ static int wm8524_mute_stream(struct
> snd_soc_dai
> > *dai, int mute, int stream)
> >
> >  #define WM8524_RATES SNDRV_PCM_RATE_8000_192000
> >
> > -#define WM8524_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |
> > SNDRV_PCM_FMTBIT_S24_LE)
> > +#define WM8524_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |\
> > +                     SNDRV_PCM_FMTBIT_S24_LE |\
> > +                     SNDRV_PCM_FMTBIT_S32_LE)
> >
> 
> The device doesn't actually support 32bit though, I guess it will ignore the
> extra LSBs so it should work. But is that really supporting 32 bit?
> 
I also think it may ignore the extra LSBs just as you said, but don't really
Support 32bit.  This change is to make driver accept S32_LE format.

Best regards
Wang shengjiu