linux-kernel - Re: drivers/cpufreq/brcmstb-avs-cpufreq.c:449: bad test ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191105064735.t6qiz2kc266em7vi@vireshk-i7>
Date:   Tue, 5 Nov 2019 12:17:35 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     David Binderman <dcb314@...mail.com>
Cc:     "mmayer@...adcom.com" <mmayer@...adcom.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: drivers/cpufreq/brcmstb-avs-cpufreq.c:449: bad test ?

On 28-10-19, 15:18, David Binderman wrote:
> Hello there,
> 
> drivers/cpufreq/brcmstb-avs-cpufreq.c:449:61: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
> 
> Source code is
> 
>     return (magic == AVS_FIRMWARE_MAGIC) && ((rc != -ENOTSUPP) ||
>         (rc != -EINVAL));
> 
> Maybe better code:
> 
>     return (magic == AVS_FIRMWARE_MAGIC) && (rc != -ENOTSUPP) &&
>         (rc != -EINVAL);

Right. Care to send a proper patch for this ?

-- 
viresh