linux-kernel - Re: [PATCH] nvme: change nvme_passthru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <442718702.90376810.1572939552776.JavaMail.zimbra@kalray.eu>
Date:   Tue, 5 Nov 2019 08:39:12 +0100 (CET)
From:   Marta Rybczynska <mrybczyn@...ray.eu>
To:     Charles Machalow <csm10495@...il.com>
Cc:     linux-nvme <linux-nvme@...ts.infradead.org>,
        kbusch <kbusch@...nel.org>, axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark
 rsvd



----- On 5 Nov, 2019, at 07:15, Charles Machalow csm10495@...il.com wrote:

> Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit
> marker for the padding space added on certain platforms as a result of the
> enlargement of the result field from 32 bit to 64 bits in size.
> ---
> include/uapi/linux/nvme_ioctl.h | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/nvme_ioctl.h b/include/uapi/linux/nvme_ioctl.h
> index e168dc59e..d99b5a772 100644
> --- a/include/uapi/linux/nvme_ioctl.h
> +++ b/include/uapi/linux/nvme_ioctl.h
> @@ -63,6 +63,7 @@ struct nvme_passthru_cmd64 {
> 	__u32	cdw14;
> 	__u32	cdw15;
> 	__u32	timeout_ms;
> +	__u32   rsvd2;
> 	__u64	result;
> };
> 

Looks good to me. However, please note that the new ioctl made it already to 5.3.8.

Regards,
Marta