[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOQ4uxhoozGgxYmucFpFx8N=b4x9H3sfp60TNzf0dmU9eQi2UQ@mail.gmail.com>
Date: Tue, 5 Nov 2019 09:56:04 +0200
From: Amir Goldstein <amir73il@...il.com>
To: Mark Salyzyn <salyzyn@...roid.com>
Cc: linux-kernel <linux-kernel@...r.kernel.org>,
kernel-team@...roid.com, Miklos Szeredi <miklos@...redi.hu>,
Jonathan Corbet <corbet@....net>,
Vivek Goyal <vgoyal@...hat.com>,
"Eric W . Biederman" <ebiederm@...ssion.com>,
Randy Dunlap <rdunlap@...radead.org>,
Stephen Smalley <sds@...ho.nsa.gov>,
overlayfs <linux-unionfs@...r.kernel.org>,
linux-doc@...r.kernel.org
Subject: Re: [PATCH v15 0/4] overlayfs override_creds=off & nested get xattr fix
On Mon, Nov 4, 2019 at 11:53 PM Mark Salyzyn <salyzyn@...roid.com> wrote:
>
> Patch series:
>
> Mark Salyzyn (4):
> Add flags option to get xattr method paired to __vfs_getxattr
Sigh.. did not get to fsdevel (again...) I already told you several times
that you need to use a shorter CC list.
> overlayfs: handle XATTR_NOSECURITY flag for get xattr method
> overlayfs: internal getxattr operations without sepolicy checking
> overlayfs: override_creds=off option bypass creator_cred
It would be better for review IMO if you rebase your series on top of
git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git ovl-unpriv
1. internal getxattr patch would be a one liner change to ovl_own_getxattr()
2. The documentation of override_creds would be much more
meaningful if it used the overlay permission model terminology
that Miklos added in his patch set and extend it
Thanks,
Amir.
Powered by blists - more mailing lists