linux-kernel - Re: [PATCH] dmaengine: dma-jz4780: add missed clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1572944472.3.0@crapouillou.net>
Date:   Tue, 05 Nov 2019 10:01:12 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare
 in remove

Hi,


Le mar., nov. 5, 2019 at 00:16, Chuhong Yuan <hslester96@...il.com> a 
écrit :
> The remove misses to disable and unprepare jzdma->clk.
> Add a call to clk_disable_unprepare to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Acked-by: Paul Cercueil <paul@...pouillou.net>

Thanks.


> ---
>  drivers/dma/dma-jz4780.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index cafb1cc065bb..66ab76b9520f 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -987,6 +987,7 @@ static int jz4780_dma_remove(struct 
> platform_device *pdev)
> 
>  	of_dma_controller_free(pdev->dev.of_node);
> 
> +	clk_disable_unprepare(jzdma->clk);
>  	free_irq(jzdma->irq, jzdma);
> 
>  	for (i = 0; i < jzdma->soc_data->nb_channels; i++)
> --
> 2.23.0
>