linux-kernel - Re: [PATCH 1/2] dt-bindings: power/supply: Document generic USB charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1572945391.3.1@crapouillou.net>
Date:   Tue, 05 Nov 2019 10:16:31 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        od@...c.me
Subject: Re: [PATCH 1/2] dt-bindings: power/supply: Document generic USB
 charger

Hi Rob,


Le lun., nov. 4, 2019 at 07:52, Rob Herring <robh+dt@...nel.org> a 
écrit :
> On Sun, Nov 3, 2019 at 4:08 PM Paul Cercueil <paul@...pouillou.net> 
> wrote:
>> 
>>  Add documentation about the devicetree bindings for the generic USB
>>  charger.
> 
> What makes it generic?

It only uses the USB PHY subsystem, which already has some half-baked 
support for chargers but not bound to the power-supply subsystem.


>> 
>>  Signed-off-by: Paul Cercueil <paul@...pouillou.net>
>>  ---
>>   .../bindings/power/supply/usb-charger.txt     | 24 
>> +++++++++++++++++++
>>   1 file changed, 24 insertions(+)
>>   create mode 100644 
>> Documentation/devicetree/bindings/power/supply/usb-charger.txt
>> 
>>  diff --git 
>> a/Documentation/devicetree/bindings/power/supply/usb-charger.txt 
>> b/Documentation/devicetree/bindings/power/supply/usb-charger.txt
>>  new file mode 100644
>>  index 000000000000..fd46734cb0e5
>>  --- /dev/null
>>  +++ b/Documentation/devicetree/bindings/power/supply/usb-charger.txt
>>  @@ -0,0 +1,24 @@
>>  +Generic USB charger bindings
>>  +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>  +
>>  +Required properties :
>>  + - compatible : should be "usb-charger"
>>  + - phys: phandle to the USB PHY
>>  +
>>  +Example:
>>  +
>>  +usb_con: extcon {
>>  +       compatible = "linux,extcon-usb-gpio";
>>  +       vbus-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>;
>>  +};
>>  +
>>  +usb_phy: usb-phy@0 {
>>  +       compatible = "usb-nop-xceiv";
>>  +       #phy-cells = <0>;
>>  +       extcon = <&usb_con>;
> 
> extcon is deprecated in favor of usb-connector binding. See
> .../bindings/connector/usb-connector.txt. There's also some pending
> patches for adding GPIO based connector controls including Vbus sense
> (GPIO input) and control (regulator via a GPIO).
> 
> Rob

I understand that the usb-connector binding is better, but the current 
code doesn't integrate at all with the USB PHY subsystem, which has its 
own code to handle ID and VBUS GPIOs and supports notifiers. Is that 
deprecated then?

What's the big picture here?

Thanks,
-Paul