linux-kernel - Re: [PATCH] smpboot: reuse timer calibration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1911051103280.17054@nanos.tec.linutronix.de>
Date:   Tue, 5 Nov 2019 11:05:45 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Peter Zijlstra <peterz@...radead.org>
cc:     Paul Menzel <pmenzel@...gen.mpg.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Arjan van de Ven <arjan@...ux.intel.com>, x86@...nel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] smpboot: reuse timer calibration

On Tue, 29 Oct 2019, Peter Zijlstra wrote:
> On Tue, Oct 29, 2019 at 03:19:57PM +0100, Paul Menzel wrote:
> > From: Arjan van de Ven <arjan@...ux.intel.com>
> > Date: Wed, 11 Feb 2015 17:28:14 -0600
> > 
> > NO point recalibrating for known-constant tsc ...
> > saves 200ms+ of boot time.
> > 
> > Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
> > ---
> > 
> > Arjan, can your Signed-off-by line be added? On what device, did you test
> > this?
> 
> This patch makes no sense what so ever given the current function, also
> it hard codes 0 as being the BSP.
> 
> All of this for platforms (!constant_tsc) that barely exist anymore.

And it's only an issue on multi-socket systems with !constant_tsc, which
are even more rare.

Thanks,

	tglx