linux-kernel - Re: [PATCH] scsi: megaraid_sas: Use common error handling code in megasas_mgmt_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGRGNgU9=Ng60QE_-f8fs5HzDTFQ_8R3taidERAocBc1nQwbXg@mail.gmail.com>
Date:   Tue, 5 Nov 2019 21:20:25 +1100
From:   Julian Calaby <julian.calaby@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Sumit Saxena <sumit.saxena@...adcom.com>,
        Markus Elfring <Markus.Elfring@....de>,
        Linux SCSI List <linux-scsi@...r.kernel.org>,
        "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...adcom.com>,
        "James E. J. Bottomley" <jejb@...ux.ibm.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors <kernel-janitors@...r.kernel.org>,
        Chandrakanth Patil <chandrakanth.patil@...adcom.com>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH] scsi: megaraid_sas: Use common error handling code in megasas_mgmt_ioctl_fw()

Hi,

On Tue, Nov 5, 2019 at 8:41 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> On Tue, Nov 05, 2019 at 02:58:35PM +0530, Sumit Saxena wrote:
> > On Fri, Nov 1, 2019 at 3:06 AM Markus Elfring <Markus.Elfring@....de> wrote:
> > >
> > > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > > Date: Thu, 31 Oct 2019 22:23:02 +0100
> > >
> > > Move the same error code assignments so that such exception handling
> > > can be better reused at the end of this function.
> > >
> > > This issue was detected by using the Coccinelle software.
> > >
> > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> >
> > Acked-by: Sumit Saxena <sumit.saxena@...adcom.com>
> >
>
> The code was a lot better originally...  :(

Agreed, this is a lot of stuffing around to save 3 lines.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/