linux-kernel - Re: [PATCH v5 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191105105808.GA27999@lst.de>
Date:   Tue, 5 Nov 2019 11:58:08 +0100
From:   Torsten Duwe <duwe@....de>
To:     Maxime Ripard <mripard@...nel.org>
Cc:     Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Icenowy Zheng <icenowy@...c.io>,
        Sean Paul <seanpaul@...omium.org>,
        Vasily Khoruzhick <anarsoul@...il.com>,
        Harald Geyer <harald@...ib.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter
 binding

On Tue, Nov 05, 2019 at 11:43:42AM +0100, Maxime Ripard wrote:
> 
> On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote:
> > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
> > for portable devices.
> >
> > Add a binding document for it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> > Signed-off-by: Vasily Khoruzhick <anarsoul@...il.com>
> > Reviewed-by: Rob Herring <robh@...nel.org>
> > Signed-off-by: Torsten Duwe <duwe@...e.de>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> Applied, thanks

Re-thanks!

> (still, there's one comment below that can be addressed in a
> subsequent patch).
> 
> > +
> > +  ports:
> > +    type: object
> > +
> > +    properties:
> > +      port@0:
> > +        type: object
> > +        description: |
> > +          Video port for LVTTL input
> > +
> > +      port@1:
> > +        type: object
> > +        description: |
> > +          Video port for eDP output (panel or connector).
> > +          May be omitted if EDID works reliably.
> > +
> > +    required:
> > +      - port@0
> 
> You should have something like:
> 
> ports:
>   type: object
>   additionalProperties: false
> 
> as well...

Yes, and it also struck me that I forgot at least about the hotplug-gpio.
It's unused on the Teres and the Pinebook, but in theory it's a valid
property, which can't be added any more now.

	Torsten