linux-kernel - Re: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191105113757.7emblygbcqfa6gyl@fsr-ub1664-175>
Date:   Tue, 5 Nov 2019 11:37:58 +0000
From:   Abel Vesa <abel.vesa@....com>
To:     Peng Fan <peng.fan@....com>
CC:     "sboyd@...nel.org" <sboyd@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Leonard Crestez <leonard.crestez@....com>
Subject: Re: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant
 initialization

On 19-11-04 10:11:37, Peng Fan wrote:
> From: Peng Fan <peng.fan@....com>
> 
> There is no need to initialize flags as 0.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>

Reviewed-by: Abel Vesa <abel.vesa@....com>

> ---
>  drivers/clk/imx/clk-divider-gate.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
> index 214e18eb2b22..4145594af53b 100644
> --- a/drivers/clk/imx/clk-divider-gate.c
> +++ b/drivers/clk/imx/clk-divider-gate.c
> @@ -43,7 +43,7 @@ static unsigned long clk_divider_gate_recalc_rate(struct clk_hw *hw,
>  {
>  	struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
>  	struct clk_divider *div = to_clk_divider(hw);
> -	unsigned long flags = 0;
> +	unsigned long flags;
>  	unsigned int val;
>  
>  	spin_lock_irqsave(div->lock, flags);
> @@ -75,7 +75,7 @@ static int clk_divider_gate_set_rate(struct clk_hw *hw, unsigned long rate,
>  {
>  	struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
>  	struct clk_divider *div = to_clk_divider(hw);
> -	unsigned long flags = 0;
> +	unsigned long flags;
>  	int value;
>  	u32 val;
>  
> @@ -104,7 +104,7 @@ static int clk_divider_enable(struct clk_hw *hw)
>  {
>  	struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
>  	struct clk_divider *div = to_clk_divider(hw);
> -	unsigned long flags = 0;
> +	unsigned long flags;
>  	u32 val;
>  
>  	if (!div_gate->cached_val) {
> @@ -127,7 +127,7 @@ static void clk_divider_disable(struct clk_hw *hw)
>  {
>  	struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
>  	struct clk_divider *div = to_clk_divider(hw);
> -	unsigned long flags = 0;
> +	unsigned long flags;
>  	u32 val;
>  
>  	spin_lock_irqsave(div->lock, flags);
> -- 
> 2.16.4
>