linux-kernel - Re: [PATCH] perf tools: Fix time sorting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191105132227.GA3636@kernel.org>
Date:   Tue, 5 Nov 2019 10:22:27 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <ak@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Michael Petlan <mpetlan@...hat.com>
Subject: Re: [PATCH] perf tools: Fix time sorting

Em Tue, Nov 05, 2019 at 01:41:50PM +0100, Jiri Olsa escreveu:
> On Tue, Nov 05, 2019 at 08:49:41AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Nov 04, 2019 at 04:48:54PM -0800, Andi Kleen escreveu:
> > > On Tue, Nov 05, 2019 at 12:27:11AM +0100, Jiri Olsa wrote:
> > > > The final sort might get confused when the comparison
> > > > is done over bigger numbers than int like for -s time.
> > > > 
> > > > Check following report for longer workloads:
> > > >   $ perf report -s time -F time,overhead --stdio
> > > > 
> > > > Fixing hist_entry__sort to properly return int64_t and
> > > > not possible cut int.
> > > > 
> > > > Cc: Andi Kleen <ak@...ux.intel.com>
> > > > Link: http://lkml.kernel.org/n/tip-uetl5z1eszpubzqykvdftaq6@git.kernel.org
> > > > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > > 
> > > Looks good.
> > > 
> > > Reviewed-by: Andi Kleen <ak@...ux.intel.com>
> > 
> > Thanks, applied after adding:
> > 
> > Fixes: 043ca389a318 ("perf tools: Use hpp formats to sort final output")
> > Cc: stable@...r.kernel.org # v3.16+
> 
> I was wondering about putting some commit there,
> because it was there for long time.. but that
> commit you use seems to be old enough.. ;-)

Yeah, I think it predates that, but the one I picked should have fixed
that problem, as it was touching these routines, so I thought would be a
good one to stick in a fixes tag :-)

- Arnaldo
 
> thanks,
> jirka

-- 

- Arnaldo