linux-kernel - Re: [PATCH 00/12] staging: dpaa2-ethsw: add support for control interface traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39cf7504-7599-83bb-4b53-5a25ff9240a8@nxp.com>
Date:   Tue, 5 Nov 2019 14:22:10 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Andrew Lunn <andrew@...n.ch>, Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>
Subject: Re: [PATCH 00/12] staging: dpaa2-ethsw: add support for control
 interface traffic

On 05.11.2019 16:03, Andrew Lunn wrote:
> On Tue, Nov 05, 2019 at 02:24:35PM +0100, Greg KH wrote:
>> On Tue, Nov 05, 2019 at 02:34:23PM +0200, Ioana Ciornei wrote:
>>> This patch set adds support for Rx/Tx capabilities on switch port interfaces.
>>> Also, control traffic is redirected through ACLs to the CPU in order to
>>> enable proper STP protocol handling.
>   
>> I thought I asked for no new features until this code gets out of
>> staging?  Only then can you add new stuff.  Please work to make that
>> happen first.
> 
> Hi Greg
> 
> This is in response to my review of the code in staging. The current
> code is missing a core feature for an Ethernet switch driver, being
> able to send/receive frames from the host. At the moment it can only
> control the hardware for how it switches Ethernet frames coming
> into/going out of external ports.
> 
> One of the core ideas behind how linux handles Ethernet switches is
> that they are just a bunch of network interfaces. And currently, these
> network interfaces cannot send/receive. We would never move an
> Ethernet driver out of staging which cannot send/receive, so i don't
> see why we should move an Ethernet switch driver out of staging which
> also cannot send/receive.
> 
> Maybe this patchset could be minimised. The STP handling is just nice
> to have, and could wait until the driver has moved into the main tree.
> 
>     Andrew
> 


Hi Andrew,

Just to clarify...if the STP handling is removed, then we'll have a 
receive code path but no frame will reach it.
This is because, the only way we could direct traffic to the CPU is by 
adding an ACL rule.

Is that something that the netdev community would maybe accept?

Ioana