linux-kernel - Re: [PATCH 4.14 67/95] UAS: Revert commit 3ae62a42090f ("UAS: fix alignment of scatter/gather segments")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1572964421.2921.20.camel@suse.com>
Date:   Tue, 05 Nov 2019 15:33:41 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, Alan Stern <stern@...land.harvard.edu>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 4.14 67/95] UAS: Revert commit 3ae62a42090f ("UAS: fix
 alignment of scatter/gather segments")

Am Montag, den 04.11.2019, 22:45 +0100 schrieb Greg Kroah-Hartman:
> There is no longer any reason to keep the virt_boundary_mask setting
> in the uas driver.  It was needed in the first place only for
> handling devices with a block size smaller than the maxpacket size and
> where the host controller was not capable of fully general
> scatter-gather operation (that is, able to merge two SG segments into
> a single USB packet).  But:
> 
>         High-speed or slower connections never use a bulk maxpacket
>         value larger than 512;
> 
>         The SCSI layer does not handle block devices with a block size
>         smaller than 512 bytes;
> 
>         All the host controllers capable of SuperSpeed operation can
>         handle fully general SG;
> 
>         Since commit ea44d190764b ("usbip: Implement SG support to
>         vhci-hcd and stub driver") was merged, the USB/IP driver can
>         also handle SG.

Hi,

same story as in 4.4.x, I am afraid.

	Regards
		Oliver