linux-kernel - Re: [PATCH v2] hp100: remove set but not used variable val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191105144329.GG10409@kadam>
Date:   Tue, 5 Nov 2019 17:43:29 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Chen Wandun <chenwandun@...wei.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        perex@...ex.cz, gregkh@...uxfoundation.org,
        kstewart@...uxfoundation.org, allison@...utok.net,
        tglx@...utronix.de, joe@...ches.com
Subject: Re: [PATCH v2] hp100: remove set but not used variable val

On Tue, Nov 05, 2019 at 10:36:59PM +0800, Chen Wandun wrote:
> From: Chenwandun <chenwandun@...wei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/staging/hp/hp100.c: In function hp100_start_xmit:
> drivers/staging/hp/hp100.c:1629:10: warning: variable val set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Chenwandun <chenwandun@...wei.com>
> ---

You should explain why you are sending a v2 under the --- cut off line.

The v1 was the correct patch, but this driver is going to be deleted
soon so I don't think we are accepting this sort of cleanup.

regards,
dan carpenter