linux-kernel - Re: [PATCH 4.19 114/149] UAS: Revert commit 3ae62a42090f ("UAS: fix alignment of scatter/gather segments")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1911051007140.1678-100000@iolanthe.rowland.org>
Date:   Tue, 5 Nov 2019 10:09:54 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Oliver Neukum <oneukum@...e.com>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 4.19 114/149] UAS: Revert commit 3ae62a42090f ("UAS: fix
 alignment of scatter/gather segments")

On Tue, 5 Nov 2019, Oliver Neukum wrote:

> Am Montag, den 04.11.2019, 22:45 +0100 schrieb Greg Kroah-Hartman:
> >         Since commit ea44d190764b ("usbip: Implement SG support to
> >         vhci-hcd and stub driver") was merged, the USB/IP driver can
> >         also handle SG.
> 
> Hi,
> 
> same story as 4.4.x

I'm not sure about uas, but it was reported just yesterday that the 
corresponding commit for usb-storage caused a 30% speed degradation:

	https://marc.info/?l=linux-usb&m=157293660212040&w=2

Given this information, perhaps you will decide that the revert is 
worthwhile.

Alan Stern