linux-kernel - Re: [PATCH 3/5] rtnetlink: allow RTM_NEWLINK to act upon interfaces in arbitrary namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f479405c-9372-68fb-762e-519f3bfdd333@6wind.com>
Date:   Tue, 5 Nov 2019 16:43:18 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Jonas Bonn <jonas@...rbonn.se>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     davem@...emloft.net
Subject: Re: [PATCH 3/5] rtnetlink: allow RTM_NEWLINK to act upon interfaces
 in arbitrary namespaces

Le 05/11/2019 à 09:11, Jonas Bonn a écrit :
> RTM_NEWLINK can be used mostly interchangeably with RTM_SETLINK for
> modifying device configuration.  As such, this method requires the same
> logic as RTM_SETLINK for finding the device to act on.
> 
> With this patch, the IFLA_TARGET_NETNSID selects the namespace in which
> to search for the interface to act upon.  This allows, for example, to
> set the namespace of an interface outside the current namespace by
> selecting it with the (IFLA_TARGET_NETNSID,ifi->ifi_index) pair and
> specifying the namespace with one of IFLA_NET_NS_[PID|FD].
> 
> Since rtnl_newlink branches off into do_setlink, we need to provide the
> same backwards compatibility check as we do for RTM_SETLINK:  if the
> device is not found in the namespace given by IFLA_TARGET_NETNSID then
> we search for it in the current namespace.  If found there, it's
> namespace will be changed, as before.
> 
> Signed-off-by: Jonas Bonn <jonas@...rbonn.se>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>