linux-kernel - Re: [PATCH] dma/zx/remove: Removed dmam_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191105165855.GC952516@vkoul-mobl>
Date:   Tue, 5 Nov 2019 22:28:55 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Satendra Singh Thakur <sst2005@...il.com>
Cc:     Jun Nie <jun.nie@...aro.org>, Shawn Guo <shawnguo@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma/zx/remove: Removed dmam_pool_destroy from remove
 method

On 24-10-19, 09:46, Satendra Singh Thakur wrote:
> In the probe method dmam_pool_create is used. Therefore, there is no
> need to explicitly call dmam_pool_destroy in remove method as this
> will be automatically taken care by devres

Please do not reinvent system tags, git log is your friend to check for
the tags to be used.

In this case, it is dmaengine: zx: remove ...


> 
> Signed-off-by: Satendra Singh Thakur <sst2005@...il.com>
> ---
>  drivers/dma/zx_dma.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c
> index 9f4436f7c914..7e4e457ac6d5 100644
> --- a/drivers/dma/zx_dma.c
> +++ b/drivers/dma/zx_dma.c
> @@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op)
>  		list_del(&c->vc.chan.device_node);
>  	}
>  	clk_disable_unprepare(d->clk);
> -	dmam_pool_destroy(d->pool);
>  
>  	return 0;
>  }
> -- 
> 2.17.1

-- 
~Vinod