linux-kernel - Re: [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191105171827.GE8309@piout.net>
Date:   Tue, 5 Nov 2019 18:18:27 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-rtc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rtc: brcmstb-waketimer: add missed
 clk_disable_unprepare

On 06/11/2019 00:00:43+0800, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare to fix it.
> 
> Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> ---
> Changes in v2:
>   - Remove the check for timer->clk and add fixes tag.
> 
>  drivers/rtc/rtc-brcmstb-waketimer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com