linux-kernel - Re: [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0196570-9140-c775-742c-89092056e651@st.com>
Date:   Wed, 6 Nov 2019 19:51:56 +0000
From:   Benjamin GAIGNARD <benjamin.gaignard@...com>
To:     Rob Herring <robh@...nel.org>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Linux PWM List <linux-pwm@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Hartmut Knaack <knaack.h@....de>,
        Fabrice GASNIER <fabrice.gasnier@...com>,
        Lee Jones <lee.jones@...aro.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger
 bindings to json-schema


On 11/6/19 5:06 AM, Rob Herring wrote:
> On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote:
>> Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@...nel.org> a écrit :
>>> On Thu, 31 Oct 2019 13:30:38 +0100
>>> Benjamin Gaignard <benjamin.gaignard@...com> wrote:
>>>
>>>> Convert the STM32 IIO trigger binding to DT schema format using json-schema
>>>>
>>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
>>> I'm far from great on these as still haven't taken the time I should to learn
>>> the yaml syntax properly.  A few comments inline however based mostly on this
>>> doesn't quite look like other ones I've seen recently.
>>>
>>> Thanks,
>>>
>>> Jonathan
>>>
>>>> ---
>>>>   .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++
>>>>   .../bindings/iio/timer/stm32-timer-trigger.txt     | 25 ------------
>>>>   2 files changed, 44 insertions(+), 25 deletions(-)
>>>>   create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
>>>>   delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
>>>> new file mode 100644
>>>> index 000000000000..1c8c8b55e8cd
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
>>>> @@ -0,0 +1,44 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: STMicroelectronics STM32 Timers IIO timer bindings
>>>> +
>>>> +maintainers:
>>>> +  - Benjamin Gaignard <benjamin.gaignard@...com>
>>>> +  - Fabrice Gasnier <fabrice.gasnier@...com>
>>>> +
>>>> +properties:
>>>> +  $nodemane:
>>> nodename?
>> That will be in v2
> No, $nodename is correct. The '$' signifies something we generate and
> add in. IOW, not a real property. I guess we could have used 'name' here
> and stuck with traditional OpenFirmware.
let's go for $name
>>>> +    pattern: "^timer@[0-9]+$"
>>>> +    type: object
>>>> +
>>>> +    description:
>>>> +      must be a sub-node of an STM32 Timer device tree node
>>>> +
>>>> +    properties:
>>>> +      compatible:
>>>> +        oneOf:
>>> enum is I think preferred for these.
>> as you like it will be in v2
>>
>>>> +          - const: st,stm32-timer-trigger
>>>> +          - const: st,stm32h7-timer-trigger
>>>> +
>>>> +      reg: true
>>> Normally some info for what the reg value is..
>> I can't put "description" on this field because the syntax doesn't allow it.
>> I will add a comment in v2 to explain what reg is.
> items:
>    - maximum: <max timer number>

reg is an index from 0 up to X, I will try with your syntax.

Thanks,

Benjamin

>
> Rob