linux-kernel - Re: [BUGFIX PATCH 3/4] perf probe: Fix to show calling lines of inlined functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191106200843.GD13829@kernel.org>
Date:   Wed, 6 Nov 2019 17:08:43 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [BUGFIX PATCH 3/4] perf probe: Fix to show calling lines of
 inlined functions

Em Wed, Oct 30, 2019 at 04:09:40PM +0900, Masami Hiramatsu escreveu:
> Fix to show calling lines of inlined functions (where an
> inline function is called).
> 
> die_walk_lines() filtered out the lines inside inlined functions
> based on the address. However this also filtered out the lines
> which call those inlined functions from the target function.
> 
> To solve this issue, check the call_file and call_line attributes
> and do not filter out if it matches to the line information.
> 
> Without this fix, perf probe -L doesn't show some lines correctly.
> (don't see the lines after 17)

Thanks, tested before and after and applied,

- Arnaldo