[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191106203542.uab6bwgdrkb627q4@ti.com>
Date: Wed, 6 Nov 2019 14:35:42 -0600
From: Benoit Parrot <bparrot@...com>
To: Sakari Ailus <sakari.ailus@....fi>
CC: Hans Verkuil <hverkuil@...all.nl>, <linux-media@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Jyri Sarha <jsarha@...com>
Subject: Re: [Patch v2 07/20] media: ti-vpe: cal: add CSI2 PHY LDO errata
support
Sakari Ailus <sakari.ailus@....fi> wrote on Wed [2019-Nov-06 10:55:02 +0200]:
> Hi Benoit,
>
> On Mon, Nov 04, 2019 at 01:31:27PM -0600, Benoit Parrot wrote:
>
> ...
>
> > @@ -458,6 +483,8 @@
> > #define CAL_CSI2_PHY_REG1_CLOCK_MISS_DETECTOR_STATUS_SUCCESS 0
> > #define CAL_CSI2_PHY_REG1_RESET_DONE_STATUS_MASK GENMASK(29, 28)
> >
> > +#define CAL_CSI2_PHY_REG10_I933_LDO_DISABLE_MASK BIT_MASK(6)
>
> BIT(6) ?
>
> BIT_MASK() is intended for a different purpose.
Wow, good catch, I have never realized that.
Benoit
>
> --
> Regards,
>
> Sakari Ailus
Powered by blists - more mailing lists