linux-kernel - Re: [PATCH v2 7/8] ALSA: aloop: Support selection of snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201911070543.8VTyXOLn%lkp@intel.com>
Date:   Thu, 7 Nov 2019 05:25:23 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andrew Gabbasov <andrew_gabbasov@...tor.com>
Cc:     kbuild-all@...ts.01.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Timo Wischer <twischer@...adit-jv.com>,
        Andrew Gabbasov <andrew_gabbasov@...tor.com>
Subject: Re: [PATCH v2 7/8] ALSA: aloop: Support selection of snd_timer
 instead of jiffies

Hi Andrew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on sound/for-next]
[also build test WARNING on v5.4-rc6 next-20191106]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Andrew-Gabbasov/ALSA-aloop-Support-sound-timer-as-clock-source-instead-of-jiffies/20191106-073459
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: i386-randconfig-c004-201944 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/init.h:5:0,
                    from sound/drivers/aloop.c:18:
   sound/drivers/aloop.c: In function 'loopback_parse_timer_id':
   sound/drivers/aloop.c:1063:8: error: 'snd_cards' undeclared (first use in this function); did you mean 'snd_card'?
       if (snd_cards[card] &&
           ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> sound/drivers/aloop.c:1063:4: note: in expansion of macro 'if'
       if (snd_cards[card] &&
       ^~
   sound/drivers/aloop.c:1063:8: note: each undeclared identifier is reported only once for each function it appears in
       if (snd_cards[card] &&
           ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> sound/drivers/aloop.c:1063:4: note: in expansion of macro 'if'
       if (snd_cards[card] &&
       ^~

vim +/if +1063 sound/drivers/aloop.c

  1039	
  1040	static int loopback_parse_timer_id(const char * const str,
  1041					   struct snd_timer_id *tid)
  1042	{
  1043		/* [<pref>:](<card name>|<card idx>)[{.,}<dev idx>[{.,}<subdev idx>]] */
  1044		const char * const sep_dev = ".,";
  1045		const char * const sep_pref = ":";
  1046		const char *name = str;
  1047		char save, *sep;
  1048		int card = 0, device = 0, subdevice = 0;
  1049		int err;
  1050	
  1051		sep = strpbrk(str, sep_pref);
  1052		if (sep)
  1053			name = sep + 1;
  1054		sep = strpbrk(name, sep_dev);
  1055		if (sep) {
  1056			save = *sep;
  1057			*sep = '\0';
  1058		}
  1059		err = kstrtoint(name, 0, &card);
  1060		if (err == -EINVAL) {
  1061			/* Must be the name, not number */
  1062			for (card = 0; card < snd_ecards_limit; card++) {
> 1063				if (snd_cards[card] &&
  1064				    !strcmp(snd_cards[card]->id, name)) {
  1065					err = 0;
  1066					break;
  1067				}
  1068			}
  1069		}
  1070		if (!err && sep) {
  1071			char save2, *sep2;
  1072			sep2 = strpbrk(sep + 1, sep_dev);
  1073			if (sep2) {
  1074				save2 = *sep2;
  1075				*sep2 = '\0';
  1076			}
  1077			err = kstrtoint(sep + 1, 0, &device);
  1078			if (!err && sep2) {
  1079				err = kstrtoint(sep2 + 1, 0, &subdevice);
  1080			}
  1081			if (sep2)
  1082				*sep2 = save2;
  1083		}
  1084		if (!err && tid) {
  1085			tid->card = card;
  1086			tid->device = device;
  1087			tid->subdevice = subdevice;
  1088		}
  1089		if (sep)
  1090			*sep = save;
  1091		return err;
  1092	}
  1093	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (33024 bytes)