linux-kernel - Re: [PATCH v2 1/5] rtnetlink: allow RTM_SETLINK to reference other namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191106183848.3b914620@cakuba.netronome.com>
Date:   Wed, 6 Nov 2019 18:38:48 -0500
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jonas Bonn <jonas@...rbonn.se>
Cc:     nicolas.dichtel@...nd.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v2 1/5] rtnetlink: allow RTM_SETLINK to reference other
 namespaces

On Wed,  6 Nov 2019 06:39:19 +0100, Jonas Bonn wrote:
> +	if (tb[IFLA_TARGET_NETNSID]) {
> +		int32_t netnsid = nla_get_s32(tb[IFLA_TARGET_NETNSID]);
> +		tgt_net = rtnl_get_net_ns_capable(NETLINK_CB(skb).sk, netnsid);

No comments on merits but you should definitely run this through
checkpatch..