linux-kernel - Re: [PATCH 34/50] sparc: Add show_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191105.193327.1393649190609263166.davem@davemloft.net>
Date:   Tue, 05 Nov 2019 19:33:27 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dima@...sta.com
Cc:     linux-kernel@...r.kernel.org, 0x7f454c46@...il.com,
        akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
        mingo@...nel.org, jslaby@...e.com, pmladek@...e.com,
        sergey.senozhatsky@...il.com, rostedt@...dmis.org,
        penguin-kernel@...ove.SAKURA.ne.jp, sparclinux@...r.kernel.org
Subject: Re: [PATCH 34/50] sparc: Add show_stack_loglvl()

From: Dmitry Safonov <dima@...sta.com>
Date: Wed,  6 Nov 2019 03:05:25 +0000

> Currently, the log-level of show_stack() depends on a platform
> realization. It creates situations where the headers are printed with
> lower log level or higher than the stacktrace (depending on
> a platform or user).
> 
> Furthermore, it forces the logic decision from user to an architecture
> side. In result, some users as sysrq/kdb/etc are doing tricks with
> temporary rising console_loglevel while printing their messages.
> And in result it not only may print unwanted messages from other CPUs,
> but also omit printing at all in the unlucky case where the printk()
> was deferred.
> 
> Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems
> an easier approach than introducing more printk buffers.
> Also, it will consolidate printings with headers.
> 
> Introduce show_stack_loglvl(), that eventually will substitute
> show_stack().
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: sparclinux@...r.kernel.org
> [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u
> Signed-off-by: Dmitry Safonov <dima@...sta.com>

Acked-by: David S. Miller <davem@...emloft.net>