linux-kernel - Re: [PATCH v4 01/48] Input: introduce input_mt_report_slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Nov 2019 14:00:55 +0900
From:   Jiada Wang <jiada_wang@...tor.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Henrik Rydberg <rydberg@...math.org>
CC:     <jikos@...nel.org>, <benjamin.tissoires@...hat.com>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <erosca@...adit-jv.com>, <Andrew_Gabbasov@...tor.com>
Subject: Re: [PATCH v4 01/48] Input: introduce input_mt_report_slot_inactive

Hi Dmitry

thanks for your comment,
I will update accordingly in v5 patch-set

Thanks,
Jiada

On 2019/10/31 8:23, Dmitry Torokhov wrote:
> On Tue, Oct 29, 2019 at 06:13:09PM +0100, Henrik Rydberg wrote:
>> Hi Jiada,
>>
>>> input_mt_report_slot_state() ignores the tool when the slot is closed.
>>> which has caused a bit of confusion.
>>> This patch introduces input_mt_report_slot_inactive() to report slot
>>> inactive state.
>>> replaces all input_mt_report_slot_state() with
>>> input_mt_report_slot_inactive() in case of close of slot.
>>>
>>> Signed-off-by: Jiada Wang <jiada_wang@...tor.com>
>>
>> NACK on this one.
>>
>> We already discussed this patch and the potentially changed behavior to
>> existing setups stemming from ignoring the MT state.
>>
>> On the upside, what I can see this patch does exactly no difference to the
>> cases where the MT state is set, so it can be safely dropped without
>> affecting the rest of the patch series.
> 
> I guess Jiada's concern that we are forcing to pass tool type even
> though we end up ignoring it intervally, which confuses users of the API
> as they might not know what tool to specify.
> 
> How about we do:
> 
> static inline void input_mt_report_slot_inactive(struct input_dev *dev)
> {
> 	input_mt_report_slot_state(dev, 0, false);
> }
> 
> This should not change any behavior.
> 
> Thanks.
>