linux-kernel - Re: [PATCH] watchdog: make nowayout sysfs file writable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdc909d7-bf73-740e-0da0-1aad41806734@rasmusvillemoes.dk>
Date:   Wed, 6 Nov 2019 08:44:33 +0100
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     kbuild test robot <lkp@...el.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     kbuild-all@...ts.01.org, Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: make nowayout sysfs file writable

On 05/11/2019 22.16, kbuild test robot wrote:

>    In file included from include/linux/mutex.h:14:0,
>                     from include/linux/kernfs.h:12,
>                     from include/linux/sysfs.h:16,
>                     from include/linux/kobject.h:20,
>                     from include/linux/cdev.h:5,
>                     from drivers/watchdog/watchdog_dev.c:31:
>    drivers/watchdog/watchdog_dev.c: In function 'nowayout_store':
>>> arch/ia64/include/asm/current.h:16:19: error: expected identifier or '(' before 'struct'
>     #define current ((struct task_struct *) ia64_getreg(_IA64_REG_TP))
>                       ^
>    drivers/watchdog/watchdog_dev.c:460:22: note: in expansion of macro 'current'
>      unsigned int value, current;
>                          ^~~~~~~

:facecpalm:

And it happened to work just fine in my test because I was targeting
ppc32 where unlike most other arches, current is not a macro but a
(more-or-less) ordinary global declaration

register struct task_struct *current asm ("r2");

Oh well, already fixed in v2 which dropped current for other reasons.

Rasmus