linux-kernel - Re: [PATCH net-next] net: dsa: Fix use after free in dsa_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191105.175512.1515216386686066366.davem@davemloft.net>
Date:   Tue, 05 Nov 2019 17:55:12 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, rmk+kernel@...linux.org.uk,
        hkallweit1@...il.com, andrew@...n.ch, vivien.didelot@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: Fix use after free in
 dsa_switch_remove()

From: Florian Fainelli <f.fainelli@...il.com>
Date: Sat,  2 Nov 2019 20:13:26 -0700

> The order in which the ports are deleted from the list and freed and the
> call to dsa_tree_remove_switch() is done is reversed, which leads to an
> use after free condition. Reverse the two: first tear down the ports and
> switch from the fabric, then free the ports associated with that switch
> fabric.
> 
> Fixes: 05f294a85235 ("net: dsa: allocate ports on touch")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied.