linux-kernel - Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191106095132.GA23790@phenom.ffwll.local>
Date:   Wed, 6 Nov 2019 10:51:32 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Daniel Vetter <daniel@...ll.ch>,
        Linus Walleij <linus.walleij@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using
 fwnode_gpiod_get_index()

On Tue, Nov 05, 2019 at 09:53:23PM +0200, Laurent Pinchart wrote:
> Hi Daniel,
> 
> On Tue, Nov 05, 2019 at 04:41:41PM +0100, Daniel Vetter wrote:
> > On Tue, Nov 5, 2019 at 4:29 PM Linus Walleij wrote:
> > > On Tue, Nov 5, 2019 at 1:40 AM Dmitry Torokhov wrote:
> > > > On Mon, Oct 14, 2019 at 11:43:20AM -0700, Dmitry Torokhov wrote:
> > >
> > > > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use
> > > > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but
> > > > > works with arbitrary firmware node.
> > > > >
> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > > > > ---
> > > > >
> > > > > Andrzej, Neil,
> > > > >
> > > > > This depends on the new code that can be bound in
> > > > > ib-fwnode-gpiod-get-index immutable branch of Linus' Walleij tree:
> > > > >
> > > > >         git pull git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git ib-fwnode-gpiod-get-index
> > > > >
> > > > > I hope that it would be possible to pull in this immutable branch and
> > > > > not wait until after 5.5 merge window, or, alternatively, merge through
> > > > > Linus Walleij's tree.
> > > >
> > > > Any chance this could be merged, please?
> > >
> > > I'm happy to merge it into the GPIO tree if some DRM maintainer can
> > > provide an ACK.
> > 
> > Ack.
> > 
> > > Getting ACK from DRM people is problematic and a bit of friction in the
> > > community, DVetter usually advice to seek mutual reviews etc, but IMO
> > > it would be better if some people felt more compelled to review stuff
> > > eventually. (And that has the problem that it doesn't scale.)
> > 
> > This has a review already plus if you merge your implied review.
> > That's more than good enough imo, so not seeing the issue here?
> 
> Isn't the issue that the patch should have been picked by someone for
> drm-misc ?

It requires prep work that isn't in drm-misc I thought? Anyway, Linus has
commit rights to drm-misc, could also push it there.

Plus you have, except you don't want it.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch