linux-kernel - Re: [PATCH V9 5/6] virtio: introduce a mdev based transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46df7afa-7543-ce19-7ede-9041907e2730@redhat.com>
Date:   Wed, 6 Nov 2019 21:11:15 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Cornelia Huck <cohuck@...hat.com>
Cc:     kvm@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org,
        intel-gvt-dev@...ts.freedesktop.org, kwankhede@...dia.com,
        alex.williamson@...hat.com, mst@...hat.com, tiwei.bie@...el.com,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        maxime.coquelin@...hat.com, cunming.liang@...el.com,
        zhihong.wang@...el.com, rob.miller@...adcom.com,
        xiao.w.wang@...el.com, haotian.wang@...ive.com,
        zhenyuw@...ux.intel.com, zhi.a.wang@...el.com,
        jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
        rodrigo.vivi@...el.com, airlied@...ux.ie, daniel@...ll.ch,
        farman@...ux.ibm.com, pasic@...ux.ibm.com, sebott@...ux.ibm.com,
        oberpar@...ux.ibm.com, heiko.carstens@...ibm.com,
        gor@...ux.ibm.com, borntraeger@...ibm.com, akrowiak@...ux.ibm.com,
        freude@...ux.ibm.com, lingshan.zhu@...el.com, idos@...lanox.com,
        eperezma@...hat.com, lulu@...hat.com, parav@...lanox.com,
        christophe.de.dinechin@...il.com, kevin.tian@...el.com,
        stefanha@...hat.com
Subject: Re: [PATCH V9 5/6] virtio: introduce a mdev based transport


On 2019/11/6 下午7:00, Cornelia Huck wrote:
> On Wed,  6 Nov 2019 15:05:47 +0800
> Jason Wang <jasowang@...hat.com> wrote:
>
>> This patch introduces a new mdev transport for virtio. This is used to
>> use kernel virtio driver to drive the mediated device that is capable
>> of populating virtqueue directly.
>>
>> A new virtio-mdev driver will be registered to the mdev bus, when a
>> new virtio-mdev device is probed, it will register the device with
>> mdev based config ops. This means it is a software transport between
>> mdev driver and mdev device. The transport was implemented through
>> device specific ops which is a part of mdev_parent_ops now.
>>
>> Signed-off-by: Jason Wang <jasowang@...hat.com>
>> ---
>>   drivers/virtio/Kconfig       |  13 ++
>>   drivers/virtio/Makefile      |   1 +
>>   drivers/virtio/virtio_mdev.c | 406 +++++++++++++++++++++++++++++++++++
>>   3 files changed, 420 insertions(+)
>>   create mode 100644 drivers/virtio/virtio_mdev.c
>>
>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>> index 078615cf2afc..558ac607d107 100644
>> --- a/drivers/virtio/Kconfig
>> +++ b/drivers/virtio/Kconfig
>> @@ -43,6 +43,19 @@ config VIRTIO_PCI_LEGACY
>>   
>>   	  If unsure, say Y.
>>   
>> +config VIRTIO_MDEV
>> +	tristate "MDEV driver for virtio devices"
>> +	depends on VFIO_MDEV && VIRTIO
>> +	default n
>> +	help
>> +	  This driver provides support for virtio based paravirtual
>> +	  device driver over MDEV bus. This requires your environemnt
>> +	  has appropriate virtio mdev device implementation which may
>> +	  operate on the physical device that the datapath of virtio
>> +	  could be offloaded to hardware.
> That sentence is a bit confusing to me... what about
>
> "For this to be useful, you need an appropriate virtio mdev device
> implementation that operates on a physical device to allow the datapath
> of virtio to be offloaded to hardware."
>
> ?
>
>> +
>> +	  If unsure, say M
> Building this as a module should not hurt (but please add a trailing
> '.' here :)
>
>> +
>>   config VIRTIO_PMEM
>>   	tristate "Support for virtio pmem driver"
>>   	depends on VIRTIO
> With the changes above,
>
> Reviewed-by: Cornelia Huck <cohuck@...hat.com>
>

Will post V10.

Thanks