lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Nov 2019 15:31:37 +0200
From:   Mika Westerberg <>
To:     Bjorn Helgaas <>
Cc:     "Rafael J. Wysocki" <>,
        Len Brown <>, Lukas Wunner <>,
        Keith Busch <>,
        Alex Williamson <>,
        Alexandru Gagniuc <>,
        Kai-Heng Feng <>,
        Paul Menzel <>,
        Nicholas Johnson <>,,
Subject: Re: [PATCH v2 2/2] PCI: Add missing link delays required by the PCIe

On Tue, Nov 05, 2019 at 02:01:05PM -0600, Bjorn Helgaas wrote:
> > I feel that the following is the right place to perform the delay but if
> > you think we can ignore the above, I will just do what you say and do it
> > in pci_pm_default_resume_early() (and pci_restore_standard_config() for
> > runtime path).
> > 
> > [The below diff does not have check for pci_dev->skip_bus_pm because I
> >  was planning to move it inside pci_bridge_wait_for_secondary_bus() itself.]
> What do you gain by moving it?  IIUC we want them to be the same
> condition, and if one is in pci_pm_resume_noirq() and another is
> inside pci_bridge_wait_for_secondary_bus(), it's hard to see that
> they're connected.  I'd rather have pci_pm_resume_noirq() check it
> once, save the result, and test that result before calling
> pci_pm_default_resume_early() and pci_bridge_wait_for_secondary_bus().

Fair enough :)

Powered by blists - more mailing lists