linux-kernel - Re: [PATCH v2 2/8] ALSA: aloop: loopback_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h4kzh3sxj.wl-tiwai@suse.de>
Date:   Wed, 06 Nov 2019 16:50:32 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Andrew Gabbasov <andrew_gabbasov@...tor.com>
Cc:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Timo Wischer <twischer@...adit-jv.com>
Subject: Re: [PATCH v2 2/8] ALSA: aloop: loopback_timer_start: Support return of error code

On Tue, 05 Nov 2019 15:32:12 +0100,
Andrew Gabbasov wrote:
> 
> @@ -264,7 +266,7 @@ static int loopback_trigger(struct snd_pcm_substream *substream, int cmd)
>  		spin_lock(&cable->lock);	
>  		cable->running |= stream;
>  		cable->pause &= ~stream;
> -		loopback_timer_start(dpcm);
> +		err = loopback_timer_start(dpcm);
>  		spin_unlock(&cable->lock);
>  		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>  			loopback_active_notify(dpcm);

Will we notify even if the start/stop fails?


thanks,

Takashi