linux-kernel - Re: [PATCH v2] selftests: add tests for clone3()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191106160034.73wla62ndojfz4rq@wittgenstein>
Date:   Wed, 6 Nov 2019 17:00:35 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Adrian Reber <areber@...hat.com>
Cc:     Shuah Khan <shuah@...nel.org>,
        Eugene Syromiatnikov <esyr@...hat.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests: add tests for clone3()

On Wed, Nov 06, 2019 at 04:59:14PM +0100, Christian Brauner wrote:
> On Mon, Nov 04, 2019 at 02:18:46PM +0100, Adrian Reber wrote:
> > This adds tests for clone3() with different values and sizes
> > of struct clone_args.
> > 
> > This selftest was initially part of of the clone3() with PID selftest.
> > After that patch was almost merged Eugene sent out a couple of patches
> > to fix problems with these test.
> > 
> > This commit now only contains the clone3() selftest after the LPC
> > decision to rework clone3() with PID to allow setting the PID in
> > multiple PID namespaces including all of Eugene's patches.
> > 
> > Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>
> > Signed-off-by: Adrian Reber <areber@...hat.com>
> 
> Resending, since mutt messed-up the quoting due to a new configuration I
> was testing.
> 
> A few more comments below.
> 
> Also, would you be open to adding tests here for the newly added .stack
> and .stack_size API (cf. [1])?

Actually, forget that part for now. We can do this later in a separate
patchset.

Christian