[<prev] [next>] [day] [month] [year] [list]
Message-ID: <CAHcu+VYJGUARhN8_LcdH=rMzgZN1aGnBcjMx=onftmkR-1PMXw@mail.gmail.com>
Date: Wed, 6 Nov 2019 09:39:18 -0700
From: Daniel Campello <campello@...gle.com>
To: Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc: Nick Crews <ncrews@...omium.org>, bleung@...omium.org,
linux-leds@...r.kernel.org, jacek.anaszewski@...il.com,
pavel@....cz, linux-kernel@...r.kernel.org, arnd@...db.de,
weiyongjun1@...wei.com, dlaurie@...omium.org, djkurtz@...omium.org,
dtor@...gle.com, sjg@...omium.org, groeck@...omium.com
Subject: Re: [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight
LED support
HI again,
On Wed, Nov 6, 2019 at 9:34 AM Daniel Campello <campello@...gle.com> wrote:
>
> Hi Enric,
>
> On Wed, Nov 6, 2019 at 8:15 AM Enric Balletbo i Serra <enric.balletbo@...labora.com> wrote:
>>
>> Hi Daniel,
>>
>> On 25/10/19 0:28, Nick Crews wrote:
>> > The EC is in charge of controlling the keyboard backlight on
>> > the Wilco platform. We expose a standard LED class device
>> > named platform::kbd_backlight.
>> >
>> > Since the EC will never change the backlight level of its own accord,
>> > we don't need to implement a brightness_get() method.
>> >
>> > Signed-off-by: Nick Crews <ncrews@...omium.org>
>> > Signed-off-by: Daniel Campello <campello@...omium.org>
>>
>> As you know 0day reported an issue that needs to be solved, waiting for a new
>> version.
>>
>> Thanks,
>> Enric
>
>
> I just sent a v9 of the patch with the issue addressed.
>
> Thanks,
> Daniel
Resending in plain text format... Sorry about that...
Daniel
Powered by blists - more mailing lists