linux-kernel - Re: [PATCH 0/1] Fix bug resulting in double hpmemsize being assigned to MMIO window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7de4e19-377c-7b82-3afd-f0fe40dcc20f@deltatee.com>
Date:   Thu, 7 Nov 2019 10:25:05 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "corbet@....net" <corbet@....net>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>
Subject: Re: [PATCH 0/1] Fix bug resulting in double hpmemsize being assigned
 to MMIO window



On 2019-11-07 6:50 a.m., Nicholas Johnson wrote:
> I have split this patch off my main series, as I realised that it does 
> not need to be part of that series.
> 
> I have made some recent improvements to add assurance against it 
> breaking existing behaviour. Instead of returning the first resource of 
> the desired type regardless of it being assigned, now it goes through 
> all of the resources and returns only those of type that are not 
> assigned. Only then does it go through and return the first resource of 
> desired type that is assigned. If none are found then it returns NULL as 
> usual.
> 
> I have made extensive changes to the patch notes, also.
> 
> Logan Gunthorpe <logang@...tatee.com> has an alternative method of 
> fixing this same bug. Please also consider his patch and accept 
> whichever is best for Linux. All I care is that the bug be fixed.

Oh, yes, I haven't had time to follow up on this. My patch is here[1].
It has a bit more info in the commit message and is a bit less
intrusive. However, Nicholas's approach is more of a cleanup and may be
a bit cleaner going forward.

I also had another bug fix in that series I really need to find time to
update and resend. I'll try to do it in the next cycle.

Logan

[1]
https://lore.kernel.org/linux-pci/20190531171216.20532-2-logang@deltatee.com/