lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Nov 2019 19:41:38 +0000 From: "Ghannam, Yazen" <Yazen.Ghannam@....com> To: Borislav Petkov <bp@...en8.de> CC: "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH v3 0/5] AMD64 EDAC: Check for nodes without memory, etc. > -----Original Message----- > From: linux-edac-owner@...r.kernel.org <linux-edac-owner@...r.kernel.org> On Behalf Of Borislav Petkov > Sent: Thursday, November 7, 2019 2:34 PM > To: Ghannam, Yazen <Yazen.Ghannam@....com> > Cc: linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org > Subject: Re: [PATCH v3 0/5] AMD64 EDAC: Check for nodes without memory, etc. > > On Thu, Nov 07, 2019 at 07:20:25PM +0000, Ghannam, Yazen wrote: > > Yes, that's right. But it looks like future systems will re-use PCI IDs even > > across families and models. And the PCI IDs will be more closely related to > > hardware capabilities than family and model. > > > > In any case, we can address that when we get there. > > I'd be fine with it if this really is the case and we don't end up > having to keep adding PCI IDs like crazy again. That was a moderate > PITA, AFAIR, especially for distro kernels having to constantly pick up > enablement patches and people complaining about it. > > So you need to make sure the PCI IDs will really get reused before > converting back... > Will do. > > > if (!ecc_en || !nb_mce_en) > > > return false; > > > else > > > > Right, I meant you can drop this else and just return true. > > > > > return true; > > I prefer the regular if-else way because it reads faster and it is > straight-forward when one skims over the code. > > But I can drop if if you insist. :-) > No, I don't mind. Thanks, Yazen
Powered by blists - more mailing lists