linux-kernel - [PATCH] phy: allwinner: Fix GENMASK misuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  7 Nov 2019 21:46:45 +0100
From:   Rikard Falkeborn <rikard.falkeborn@...il.com>
To:     megous@...ous.com
Cc:     arnd@...db.de, devicetree@...r.kernel.org,
        gregkh@...uxfoundation.org, icenowy@...c.io, kishon@...com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...glegroups.com, mark.rutland@....com,
        mripard@...nel.org, paul.kocialkowski@...tlin.com,
        robh+dt@...nel.org, tglx@...utronix.de, wens@...e.org,
        Rikard Falkeborn <rikard.falkeborn@...il.com>
Subject: [PATCH] phy: allwinner: Fix GENMASK misuse

Arguments are supposed to be ordered high then low.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
---
Spotted while trying to add compile time checks of GENMASK arguments.
Patch has only been compile tested.

 drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
index 1169f3e83a6f..b1c04f71a31d 100644
--- a/drivers/phy/allwinner/phy-sun50i-usb3.c
+++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
@@ -49,7 +49,7 @@
 #define SUNXI_LOS_BIAS(n)		((n) << 3)
 #define SUNXI_LOS_BIAS_MASK		GENMASK(5, 3)
 #define SUNXI_TXVBOOSTLVL(n)		((n) << 0)
-#define SUNXI_TXVBOOSTLVL_MASK		GENMASK(0, 2)
+#define SUNXI_TXVBOOSTLVL_MASK		GENMASK(2, 0)
 
 struct sun50i_usb3_phy {
 	struct phy *phy;
-- 
2.24.0