linux-kernel - Re: [PATCH] clk: qcom: smd: Add missing pnoc clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191107214210.D70C32178F@mail.kernel.org>
Date:   Thu, 07 Nov 2019 13:42:10 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jeffrey Hugo <jeffrey.l.hugo@...il.com>, mturquette@...libre.com
Cc:     agross@...nel.org, bjorn.andersson@...aro.org,
        sibis@...eaurora.org, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jeffrey Hugo <jeffrey.l.hugo@...il.com>
Subject: Re: [PATCH] clk: qcom: smd: Add missing pnoc clock

Quoting Jeffrey Hugo (2019-11-07 11:06:15)
> When MSM8998 support was added, and analysis was done to determine what
> clocks would be consumed.  That analysis had a flaw, which caused the
> pnoc to be skipped.  The pnoc clock needs to be on to access the uart
> for the console.  The clock is on from boot, but has no consumer votes
> in the RPM.  When we attempt to boot the modem, it causes the RPM to
> turn off pnoc, which kills our access to the console and causes CPU hangs.
> 
> We need pnoc to be defined, so that clk_smd_rpm_handoff() will put in
> an implicit vote for linux and prevent issues when booting modem.
> Hopefully pnoc can be consumed by the interconnect framework in future
> so that Linux can rely on explicit votes.
> 
> Fixes: 6131dc81211c ("clk: qcom: smd: Add support for MSM8998 rpm clocks")
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@...il.com>
> ---

Applied to clk-next