linux-kernel - Re: [PATCH v6 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 07 Nov 2019 13:55:05 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jeffrey Hugo <jhugo@...eaurora.org>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org,
        marc.w.gonzalez@...e.fr, mturquette@...libre.com,
        robh+dt@...nel.org, mark.rutland@....com,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Jeffrey Hugo <jhugo@...eaurora.org>
Subject: Re: [PATCH v6 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc

Quoting Jeffrey Hugo (2019-10-01 12:57:22)
> diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
> index 8b0f7841af8d..a92f3cbc9736 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
> +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
> @@ -10,11 +10,32 @@ Required properties :
>                         "qcom,mmcc-msm8960"
>                         "qcom,mmcc-msm8974"
>                         "qcom,mmcc-msm8996"
> +                       "qcom,mmcc-msm8998"

Can you convert this binding to YAML? Makes it easier to validate it
against the dts files.

>  
>  - reg : shall contain base register location and length
>  - #clock-cells : shall contain 1
>  - #reset-cells : shall contain 1
>  
> +For MSM8998 only:
> +       - clocks: a list of phandles and clock-specifier pairs,
> +                 one for each entry in clock-names.
> +       - clock-names: "xo" for the xo clock.
> +                      "gpll0" for the global pll 0 clock.
> +                      "dsi0dsi" for the dsi0 pll dsi clock (required if dsi is
> +                               enabled, optional otherwise).
> +                      "dsi0byte" for the dsi0 pll byte clock (required if dsi
> +                               is enabled, optional otherwise).
> +                      "dsi1dsi" for the dsi1 pll dsi clock (required if dsi is
> +                               enabled, optional otherwise).
> +                      "dsi1byte" for the dsi1 pll byte clock (required if dsi
> +                               is enabled, optional otherwise).
> +                      "hdmipll" for the hdmi pll clock (required if hdmi is
> +                               enabled, optional otherwise).
> +                      "dpvco" for the displayport pll vco clock (required if
> +                               dp is enabled, optional otherwise).
> +                      "dplink" for the displayport pll link clock (required if
> +                               dp is enabled, optional otherwise).

I'm not sure why it's optional. The hardware is "fixed" in the sense
that the dp phy is always there and connected to this hardware block.
>From a driver perspective I agree it's optional to be used, but from a
DT perspective it's always there so it should be required.