linux-kernel - RE: [PATCH 0/2] drm: replace magic nuumbers

Open Source and information security mailing list archives

Message-ID: <CY4PR12MB1813997898E8B03859E5F457F7780@CY4PR12MB1813.namprd12.prod.outlook.com>
Date:   Thu, 7 Nov 2019 22:43:20 +0000
From:   "Deucher, Alexander" <Alexander.Deucher@....com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        Frederick Lawler <fred@...dlawl.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/2] drm: replace magic nuumbers

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@...ts.freedesktop.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, November 7, 2019 5:21 PM
> To: Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian
> <Christian.Koenig@....com>; Zhou, David(ChunMing)
> <David1.Zhou@....com>; David Airlie <airlied@...ux.ie>; Daniel Vetter
> <daniel@...ll.ch>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>; dri-devel@...ts.freedesktop.org;
> amd-gfx@...ts.freedesktop.org; Frederick Lawler <fred@...dlawl.com>;
> linux-kernel@...r.kernel.org
> Subject: [PATCH 0/2] drm: replace magic nuumbers
> 
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> amdgpu and radeon do a bit of mucking with the PCIe Link Control 2 register,
> some of it using hard-coded magic numbers.  The idea here is to replace
> those with #defines.
> 
> I haven't signed off on these because the first one actually changes the bits
> involved because the existing code looks like it might have a typo.
> But I have no way to know for sure.
> 

It is a typo.  Your patches look correct to me.  The series is:
Reviewed-by: Alex Deucher <alexander.deucher@....com>

> I don't intend the Target Link Speed patch to change anything, so it should be
> straightforward to review.
> 
> Bjorn Helgaas (2):
>   drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2
>     definitions
>   drm: replace Target Link Speed magic numbers with PCI_EXP_LNKCTL2
>     definitions
> 
>  drivers/gpu/drm/amd/amdgpu/cik.c | 22 ++++++++++++++--------
> drivers/gpu/drm/amd/amdgpu/si.c  | 18 +++++++++++-------
>  drivers/gpu/drm/radeon/cik.c     | 22 ++++++++++++++--------
>  drivers/gpu/drm/radeon/si.c      | 22 ++++++++++++++--------
>  include/uapi/linux/pci_regs.h    |  2 ++
>  5 files changed, 55 insertions(+), 31 deletions(-)
> 
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives