linux-kernel - Re: [PATCH v2] x86/stacktrace: update kconfig help text for reliable unwinders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191107033458.ptvw6omypqndjt6d@treble>
Date:   Wed, 6 Nov 2019 21:34:58 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Joe Lawrence <joe.lawrence@...hat.com>
Cc:     linux-kernel@...r.kernel.org, live-patching@...r.kernel.org
Subject: Re: [PATCH v2] x86/stacktrace: update kconfig help text for reliable
 unwinders

On Wed, Nov 06, 2019 at 10:29:58PM -0500, Joe Lawrence wrote:
> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@...hat.com>
> ---
> 
> v2: dropped hunk that added unnecessary text to UNWIND_GUESS
> 
>  arch/x86/Kconfig.debug | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index bf9cd83de777..409c00f74e60 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -316,10 +316,6 @@ config UNWINDER_FRAME_POINTER
>  	  unwinder, but the kernel text size will grow by ~3% and the kernel's
>  	  overall performance will degrade by roughly 5-10%.
>  
> -	  This option is recommended if you want to use the livepatch
> -	  consistency model, as this is currently the only way to get a
> -	  reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).
> -
>  config UNWINDER_GUESS
>  	bool "Guess unwinder"
>  	depends on EXPERT
> -- 
> 2.21.0
> 

Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>

-- 
Josh