[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=UjwO25HeVtYvzqEdUxyA4ED18ZxcwEaYVzBGRFTa2FTw@mail.gmail.com>
Date: Wed, 6 Nov 2019 20:24:41 -0800
From: Doug Anderson <dianders@...omium.org>
To: Taniya Das <tdas@...eaurora.org>
Cc: Stephen Boyd <sboyd@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
David Brown <david.brown@...aro.org>,
Rajendra Nayak <rnayak@...eaurora.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
linux-clk <linux-clk@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Andy Gross <agross@...nel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>,
Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v1 1/7] clk: qcom: clk-alpha-pll: Add support for Fabia
PLL calibration
Hi,
On Thu, Oct 31, 2019 at 5:21 AM Taniya Das <tdas@...eaurora.org> wrote:
>
> @@ -1141,15 +1160,11 @@ static int alpha_pll_fabia_set_rate(struct clk_hw *hw, unsigned long rate,
> unsigned long prate)
> {
> struct clk_alpha_pll *pll = to_clk_alpha_pll(hw);
> - u32 val, l, alpha_width = pll_alpha_width(pll);
> + u32 l, alpha_width = pll_alpha_width(pll);
> u64 a;
> unsigned long rrate;
> int ret = 0;
>
> - ret = regmap_read(pll->clkr.regmap, PLL_MODE(pll), &val);
> - if (ret)
> - return ret;
My compiler happened to notice that with the change to this function:
drivers/clk/qcom/clk-alpha-pll.c:1166:6: error: unused variable 'ret'
[-Werror,-Wunused-variable]
int ret = 0;
-Doug
Powered by blists - more mailing lists