linux-kernel - Re: [PATCH v2] dpaa2-ptp: fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191106.215048.716703460065134604.davem@davemloft.net>
Date:   Wed, 06 Nov 2019 21:50:48 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     chenwandun@...wei.com
Cc:     ruxandra.radulescu@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dpaa2-ptp: fix compile error

From: Chen Wandun <chenwandun@...wei.com>
Date: Thu, 7 Nov 2019 09:39:49 +0800

> From: Chenwandun <chenwandun@...wei.com>
> 
> phylink_set_port_modes will be compiled if CONFIG_PHYLINK enabled,
> dpaa2_mac_validate will be compiled if CONFIG_FSL_DPAA2_ETH enabled,
> it should select CONFIG_PHYLINK when dpaa2_mac_validate call
> phylink_set_port_modes
> 
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_validate':
> dpaa2-mac.c:(.text+0x3a1): undefined reference to `phylink_set_port_modes'
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_connect':
> dpaa2-mac.c:(.text+0x91a): undefined reference to `phylink_create'
> dpaa2-mac.c:(.text+0x94e): undefined reference to `phylink_of_phy_connect'
> dpaa2-mac.c:(.text+0x97f): undefined reference to `phylink_destroy'
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.o: In function `dpaa2_mac_disconnect':
> dpaa2-mac.c:(.text+0xa9f): undefined reference to `phylink_disconnect_phy'
> dpaa2-mac.c:(.text+0xab0): undefined reference to `phylink_destroy'
> make: *** [vmlinux] Error 1
> 
> Fixes: 719479230893 (dpaa2-eth: add MAC/PHY support through phylink)

In Fixes tags, place the commit header text in both parenthesis and
double quotes, like this:

Fixes: 719479230893 ("dpaa2-eth: add MAC/PHY support through phylink")

> Signed-off-by: Chenwandun <chenwandun@...wei.com>

Applied, thank you.