linux-kernel - Re: [PATCH 1/2] regulator: ab8500: Remove AB8505 USB regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaH8ahbVKTrBHh7NKVZVg-PZvyKDKNityEyv5rL8=Qdag@mail.gmail.com>
Date:   Thu, 7 Nov 2019 09:02:11 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stephan Gerhold <stephan@...hold.net>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: ab8500: Remove AB8505 USB regulator

On Wed, Nov 6, 2019 at 6:33 PM Stephan Gerhold <stephan@...hold.net> wrote:

> The USB regulator was removed for AB8500 in
> commit 41a06aa738ad ("regulator: ab8500: Remove USB regulator").
> It was then added for AB8505 in
> commit 547f384f33db ("regulator: ab8500: add support for ab8505").
>
> However, there was never an entry added for it in
> ab8505_regulator_match. This causes all regulators after it
> to be initialized with the wrong device tree data, eventually
> leading to an out-of-bounds array read.
>
> Given that it is not used anywhere in the kernel, it seems
> likely that similar arguments against supporting it exist for
> AB8505 (it is controlled by hardware).
>
> Therefore, simply remove it like for AB8500 instead of adding
> an entry in ab8505_regulator_match.
>
> Fixes: 547f384f33db ("regulator: ab8500: add support for ab8505")
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij