linux-kernel - Re: [PATCH v2 8/8] ALSA: aloop: Support runtime change of snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk18c860t.wl-tiwai@suse.de>
Date:   Thu, 07 Nov 2019 09:06:26 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Andrew Gabbasov <andrew_gabbasov@...tor.com>
Cc:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Timo Wischer <twischer@...adit-jv.com>
Subject: Re: [PATCH v2 8/8] ALSA: aloop: Support runtime change of snd_timer via info interface

On Tue, 05 Nov 2019 15:32:18 +0100,
Andrew Gabbasov wrote:
> 
> Show and change sound card timer source with read-write info
> file in proc filesystem. Initial string can still be set as
> module parameter.
> 
> The timer source string value can be changed at any time,
> but it is latched by PCM substream open callback (the first one
> for a particular cable). At this point it is actually used, that
> is the string is parsed, and the timer is looked up and opened.
> 
> The timer source is set for a loopback card (the same as initial
> setting by module parameter), but every cable uses the value,
> current at the moment of open.
> 
> Setting the value to empty string switches the timer to jiffies.
> 
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@...tor.com>

Unfortunately the whole code here are racy.  It may lead to a crash or
use-after-free easily.  Some locking is needed definitely.


thanks,

Takashi