linux-kernel - Re: s390/pkey: Use memdup_user() rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <604a921d-9240-f271-3f92-675df85784e6@de.ibm.com>
Date:   Thu, 7 Nov 2019 09:07:18 +0100
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Markus Elfring <Markus.Elfring@....de>,
        Joe Perches <joe@...ches.com>, linux-s390@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Ingo Franzki <ifranzki@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: s390/pkey: Use memdup_user() rather than duplicating its
 implementation



On 07.11.19 07:48, Dan Carpenter wrote:
> On Wed, Nov 06, 2019 at 07:30:19PM +0100, Christian Borntraeger wrote:
>>
>>
>> On 06.11.19 14:00, Markus Elfring wrote:
>>>>> Reuse existing functionality from memdup_user() instead of keeping
>>>>> duplicate source code.
>>>>>
>>>>> Generated by: scripts/coccinelle/api/memdup_user.cocci
>>> …
>>>>> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
>>>>
>>>> This doesn't fix anything
>>>
>>> How would you categorise the proposed source code reduction and software reuse?
>>
>> Cleanup.
>>
>> Can you please stop arguing about review feedback that is clearly right? This is not fixing 
>> anything. The Fixes tag is used to decide if something needs a backport.
> 
> Fixes tags are independent from backports.  If you want a backport you
> should CC stable.

I agree, but a Fixes tag increases the likelyhood of automatic backports anyway.
(e.g. some distro kernel maintainers check for this tag).