linux-kernel - RE: [PATCH v2] mmc: core: Fix size overflow for mmc partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR04MB69915AFED1B6AFD1B30EFBCDFC780@MN2PR04MB6991.namprd04.prod.outlook.com>
Date:   Thu, 7 Nov 2019 08:30:22 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Bradley Bolen <bradleybolen@...il.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
CC:     "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "wsa+renesas@...g-engineering.com" <wsa+renesas@...g-engineering.com>,
        "yinbo.zhu@....com" <yinbo.zhu@....com>,
        "hongjiefang@...micro.com" <hongjiefang@...micro.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] mmc: core: Fix size overflow for mmc partitions

> 
> With large eMMC cards, it is possible to create general purpose partitions that
> are bigger than 4GB.  The size member of the mmc_part struct is only an
> unsigned int which overflows for gp partitions larger than 4GB.  Change this to a
> u64 to handle the overflow.
> 
> Signed-off-by: Bradley Bolen <bradleybolen@...il.com>
Looks fine.
Avri

> ---
>  drivers/mmc/core/mmc.c   | 6 +++---
>  include/linux/mmc/card.h | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index
> c880489..fc02124 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -297,7 +297,7 @@ static void mmc_manage_enhanced_area(struct
> mmc_card *card, u8 *ext_csd)
>         }
>  }
> 
> -static void mmc_part_add(struct mmc_card *card, unsigned int size,
> +static void mmc_part_add(struct mmc_card *card, u64 size,
>                          unsigned int part_cfg, char *name, int idx, bool ro,
>                          int area_type)
>  {
> @@ -313,7 +313,7 @@ static void mmc_manage_gp_partitions(struct
> mmc_card *card, u8 *ext_csd)  {
>         int idx;
>         u8 hc_erase_grp_sz, hc_wp_grp_sz;
> -       unsigned int part_size;
> +       u64 part_size;
> 
>         /*
>          * General purpose partition feature support -- @@ -362,7 +362,7 @@
> static void mmc_manage_gp_partitions(struct mmc_card *card, u8 *ext_csd)
> static int mmc_decode_ext_csd(struct mmc_card *card, u8 *ext_csd)  {
>         int err = 0, idx;
> -       unsigned int part_size;
> +       u64 part_size;
>         struct device_node *np;
>         bool broken_hpi = false;
> 
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index
> 9b6336a..b59d35b 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -226,7 +226,7 @@ struct mmc_queue_req;
>   * MMC Physical partitions
>   */
>  struct mmc_part {
> -       unsigned int    size;   /* partition size (in bytes) */
> +       u64             size;   /* partition size (in bytes) */
>         unsigned int    part_cfg;       /* partition type */
>         char    name[MAX_MMC_PART_NAME_LEN];
>         bool    force_ro;       /* to make boot parts RO by default */
> --
> 2.7.4