linux-kernel - Re: [PATCH] mtd: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Nov 2019 10:09:44 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Artem Bityutskiy <dedekind1@...il.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: no need to check return value of debugfs_create
 functions

Hi Greg,

Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote on Thu, 7 Nov
2019 09:51:11 +0100:

> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.

I didn't know about this. Is this something new or has it been the rule
since the beginning? In the  case, don't we need a Fixes tag here?

> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Brian Norris <computersforpeace@...il.com>
> Cc: Marek Vasut <marek.vasut@...il.com>
> Cc: Miquel Raynal <miquel.raynal@...tlin.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Vignesh Raghavendra <vigneshr@...com>
> Cc: Artem Bityutskiy <dedekind1@...il.com>
> Cc: linux-mtd@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

[...]

> +
> +	d->dfs_emulate_io_failures = debugfs_create_file("tst_emulate_io_failures",
> +							 S_IWUSR, d->dfs_dir,
> +							 (void *)ubi_num,
> +							 &dfs_fops);
> +
> +	d->dfs_emulate_power_cut = debugfs_create_file("tst_emulate_power_cut",
> +						       S_IWUSR, d->dfs_dir,
> +						       (void *)ubi_num,
> +						       &dfs_fops);

Nitpick: I think we miss an empty line here. I can fix it when applying.

> +	d->dfs_power_cut_min = debugfs_create_file("tst_emulate_power_cut_min",
> +						   S_IWUSR, d->dfs_dir,
> +						   (void *)ubi_num, &dfs_fops);
> +
> +	d->dfs_power_cut_max = debugfs_create_file("tst_emulate_power_cut_max",
> +						   S_IWUSR, d->dfs_dir,
> +						   (void *)ubi_num, &dfs_fops);
> +
> +	debugfs_create_file("detailed_erase_block_info", S_IRUSR, d->dfs_dir,
> +			    (void *)ubi_num, &eraseblk_count_fops);
> +
> +	return 0;
>  }
>  
>  /**

Thanks,
Miquèl