linux-kernel - Re: [PATCH] media: c8sectpfe: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e27c1351-3ca8-ccf3-bcb6-adab33be8889@st.com>
Date:   Thu, 7 Nov 2019 09:58:46 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: c8sectpfe: no need to check return value of
 debugfs_create functions

Hi

On 11/7/19 9:52 AM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Patrice Chotard <patrice.chotard@...com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-media@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  .../sti/c8sectpfe/c8sectpfe-debugfs.c         | 26 +++----------------
>  1 file changed, 3 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> index 8f0ddcbeed9d..301fa10f419b 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-debugfs.c
> @@ -225,36 +225,16 @@ static const struct debugfs_reg32 fei_sys_regs[] = {
>  
>  void c8sectpfe_debugfs_init(struct c8sectpfei *fei)
>  {
> -	struct dentry		*root;
> -	struct dentry		*file;
> -
> -	root = debugfs_create_dir("c8sectpfe", NULL);
> -	if (!root)
> -		goto err;
> -
> -	fei->root = root;
> -
>  	fei->regset =  devm_kzalloc(fei->dev, sizeof(*fei->regset), GFP_KERNEL);
>  	if (!fei->regset)
> -		goto err;
> +		return;
>  
>  	fei->regset->regs = fei_sys_regs;
>  	fei->regset->nregs = ARRAY_SIZE(fei_sys_regs);
>  	fei->regset->base = fei->io;
>  
> -	file = debugfs_create_regset32("registers", S_IRUGO, root,
> -				fei->regset);
> -	if (!file) {
> -		dev_err(fei->dev,
> -			"%s not able to create 'registers' debugfs\n"
> -			, __func__);
> -		goto err;
> -	}
> -
> -	return;
> -
> -err:
> -	debugfs_remove_recursive(root);
> +	fei->root = debugfs_create_dir("c8sectpfe", NULL);
> +	debugfs_create_regset32("registers", S_IRUGO, fei->root, fei->regset);
>  }
>  
>  void c8sectpfe_debugfs_exit(struct c8sectpfei *fei)

Reviewed-by: Patrice Chotard <patrice.chotard@...com>

Thanks